Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sso trigger validations #1450

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: sso trigger validations #1450

merged 1 commit into from
May 2, 2023

Conversation

StereoPT
Copy link
Contributor

@StereoPT StereoPT commented May 2, 2023

Relates to:

Fixes:

Proposed Changes

  • When logging in with SSO, the page no longer triggers the form validation
  • Also it disables the SSO Button and displays loading dots to give the user some feedback

This pull request closes #1449

@StereoPT StereoPT linked an issue May 2, 2023 that may be closed by this pull request
[BUG]: SSO Login Validation #1449
Closed
@StereoPT StereoPT self-assigned this May 2, 2023
@StereoPT StereoPT requested a review from a team May 2, 2023 15:07
@StereoPT StereoPT added bug Something isn't working frontend labels May 2, 2023
@StereoPT StereoPT merged commit 29819e2 into main May 2, 2023
@StereoPT StereoPT deleted the 1449-bug-sso-login-validation branch May 2, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@StereoPT StereoPT

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: SSO Login Validation
2 participants
@StereoPT @nunocaseiro