Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: popover border in main board #1461

Merged
merged 2 commits into from
May 3, 2023
Merged

fix: popover border in main board #1461

merged 2 commits into from
May 3, 2023

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to:

Fixes:

Screenshots (if visual changes)

image

Proposed Changes

  • adding the eventPreventDefault on the onOpenAutoFocus prop

This pull request closes #1323

@GoncaloCanteiro GoncaloCanteiro added bug Something isn't working frontend labels May 3, 2023
@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone May 3, 2023
@GoncaloCanteiro GoncaloCanteiro requested a review from a team May 3, 2023 14:16
@GoncaloCanteiro GoncaloCanteiro self-assigned this May 3, 2023
@GoncaloCanteiro GoncaloCanteiro linked an issue May 3, 2023 that may be closed by this pull request
[BUG]: Safari - sub-boards merged popover border #1323
Closed
@GoncaloCanteiro GoncaloCanteiro changed the title fix: safari - sub-boards merged popover border fix: popover border in main board May 3, 2023
CatiaAntunes96
CatiaAntunes96 approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@CatiaAntunes96 CatiaAntunes96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit 88fe4bc into main May 3, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the fix/safari-sub-boards-merged-popover-border branch May 3, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatiaAntunes96 CatiaAntunes96 CatiaAntunes96 approved these changes

Assignees

@GoncaloCanteiro GoncaloCanteiro

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: Safari - sub-boards merged popover border
2 participants
@GoncaloCanteiro @CatiaAntunes96