Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Change favicon #149

Merged
merged 2 commits into from
May 5, 2022
Merged

Feat: Change favicon #149

merged 2 commits into from
May 5, 2022

Conversation

dsousa12
Copy link
Contributor

@dsousa12 dsousa12 commented May 5, 2022

Relates to #148

Screenshots

image

Proposed Changes

  • Using the Split icon as a favicon;
    • In this case I created the favicon in SVG format, but it's easy convert to ICO

This pull request is intended to close #148

@dsousa12 dsousa12 requested a review from nunocaseiro May 5, 2022 08:56
@dsousa12 dsousa12 self-assigned this May 5, 2022
nunocaseiro
nunocaseiro approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dsousa12 dsousa12 merged commit 3bf36d0 into main May 5, 2022
@dsousa12 dsousa12 deleted the feat-change-favicon branch May 5, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@dsousa12 dsousa12

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: change favicon
2 participants
@dsousa12 @nunocaseiro