-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Run project on Docker in Dev mode #151
Conversation
Note: it's necessary update the README How to run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the merge we need to modify the github actions in order to use the prod versions of the docker files. Now we have an extra folder docker
in each app. I believe we just need to update the docker build command on each github action workflow. Great job!
Working on this section in Wiki |
@nunocaseiro already done this change, can you see if everything it's ok? |
@all-contributors please add @dsousa12 as contributor for code and docs |
I've put up a pull request to add @dsousa12! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Amazing job!
Relates to #150
Screenshots (if visual changes)
It's not a visual change, but I leave some screenshots related with this change:
Hot reloading
On Frontend:
On Backend:
Proposed Changes
@xgeekshq/d-c-infra can review please?
This pull request is intended to close #150