Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: Dashboard Tiles Size #169

Merged
merged 2 commits into from
May 16, 2022
Merged

[FIX]: Dashboard Tiles Size #169

merged 2 commits into from
May 16, 2022

Conversation

dsousa12
Copy link
Contributor

Fixes #164

Screenshots (if visual changes)

image

Proposed Changes

  • Use display: grid on container instead display: flex
    • Why? with display: grid you can set the amount of columns you need (grid-template-columns: repeat(3, 1fr))
  • Use blob as a icon, creating the card manually (setting background, etc..)

This PR closes #164

@dsousa12 dsousa12 requested a review from nunocaseiro May 15, 2022 15:44
@dsousa12 dsousa12 self-assigned this May 15, 2022
nunocaseiro
nunocaseiro approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dsousa12 dsousa12 merged commit 35d1f87 into main May 16, 2022
@dsousa12 dsousa12 deleted the fix-tiles-size branch May 16, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@dsousa12 dsousa12

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX]: Block Tiles Size
2 participants
@dsousa12 @nunocaseiro