Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: userIcon and eye/eyeslash onclick #190

Merged
merged 3 commits into from
May 20, 2022
Merged

feat: userIcon and eye/eyeslash onclick #190

merged 3 commits into from
May 20, 2022

Conversation

f-morgado
Copy link
Contributor

Relates to #167

Screenshots (if visual changes)

image
image

Proposed Changes

  • userIcon from svg to Sprite symbol
  • eye/eyeslash now swaps accordingly when password is shown/hidden

f-morgado and others added 3 commits May 20, 2022 11:21
@f-morgado
fix: adapting userIcon and eyeIcon to Sprite
5b80f41
@f-morgado
Delete userIcon.svg
d78db10 
userIcon already contemplated on Sprite, no need for a .svg file
@f-morgado
fix: conflicts
a7636a7
@f-morgado f-morgado merged commit f5744e5 into main May 20, 2022
@nunocaseiro nunocaseiro deleted the feat-user-icon branch June 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-morgado @nunocaseiro