Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check user email or unique name in AD #266

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix: check user email or unique name in AD #266

merged 1 commit into from
Jun 27, 2022

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Jun 27, 2022 •
edited
Loading

Fixes #265

Proposed Changes

  • Send the unique name or the email to check if the user exists in ad

This pull request closes #265

@nunocaseiro nunocaseiro self-assigned this Jun 27, 2022
@nunocaseiro nunocaseiro marked this pull request as ready for review June 27, 2022 12:23
@nunocaseiro nunocaseiro requested a review from a team June 27, 2022 12:23
dsousa12
dsousa12 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@dsousa12 dsousa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro nunocaseiro merged commit a7913e1 into main Jun 27, 2022
@nunocaseiro nunocaseiro deleted the fix/azure-email branch June 27, 2022 12:31
@nunocaseiro nunocaseiro restored the fix/azure-email branch June 27, 2022 16:26
@nunocaseiro nunocaseiro deleted the fix/azure-email branch June 27, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsousa12 dsousa12 dsousa12 approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: AD- Use unique email if email is undefined
2 participants
@nunocaseiro @dsousa12