Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Board Settings Permissions #345

Merged
merged 12 commits into from
Jul 22, 2022
Merged

[FEATURE]: Board Settings Permissions #345

merged 12 commits into from
Jul 22, 2022

Conversation

dsousa12
Copy link
Contributor

Relates to #344

Proposed Changes

  • Validate on Frontend and Backend if the user match with:
    • Is Team Admin or Stakeholder
    • Is Responsible (only on sub-boards)
    • Is the owner
  • Add listener to when user press the enter key submit the form (on Frontend)

Discussed with @CatiaBarroco-xgeeks and @f-morgado

This pull request closes #334

@dsousa12 dsousa12 requested review from a team July 21, 2022 14:47
@dsousa12 dsousa12 self-assigned this Jul 21, 2022
@dsousa12 dsousa12 linked an issue Jul 21, 2022 that may be closed by this pull request
[FEATURE]: Board Settings Permissions #344
Closed
@CatiaBarroco-xgeeks
Copy link
Contributor

LGTM 🚀

@dsousa12 dsousa12 requested a review from dvpfran July 22, 2022 09:49
dvpfran
dvpfran approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@dvpfran dvpfran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dsousa12 dsousa12 merged commit d92470a into main Jul 22, 2022
@dsousa12 dsousa12 deleted the feat-board-settings-permissions branch July 22, 2022 11:05
dsousa12 added a commit that referenced this pull request Jul 25, 2022
@dsousa12 @CatiaBarroco-xgeeks
@f-morgado @tutods
[FEATURE]: Board Settings Permissions (#345)
607f97c 
Co-authored-by: Catia Barroco <104831678+CatiaBarroco-xgeeks@users.noreply.github.com>
Co-authored-by: Francisco Morgado <f.morgado@kigroup.de>
Co-authored-by: Daniel Sousa @tutods <jdaniel.asousa@gmail.com>
Co-authored-by: Daniel Sousa <tutods@Macbook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvpfran dvpfran dvpfran approved these changes

Assignees

@dsousa12 dsousa12

Labels
backend frontend
Projects
SPLIT • Backend
Status: Done
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Board Settings Permissions
5 participants
@dsousa12 @CatiaBarroco-xgeeks @dvpfran @f-morgado @tutods