Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: users permissions to delete boards #408

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

f-morgado
Copy link
Contributor

@f-morgado f-morgado commented Aug 17, 2022

Relates to #407

Screenshots (if visual changes)

image
image
image

Proposed Changes

  • User who has just been created and is a member can't delete existing boards
  • Users with Stakeholder, admin, SuperAdmin have permissions to delete boards
  • Users who created boards also have permission to delete their own boards

Mention people who discussed this issue previously
@CatiaBarroco-xgeeks @dsousa12 @miguel-felix1

This pull request closes #407

@f-morgado f-morgado added this to the MVP milestone Aug 17, 2022
@f-morgado f-morgado requested review from a team August 17, 2022 13:15
@f-morgado f-morgado self-assigned this Aug 17, 2022
@f-morgado f-morgado linked an issue Aug 17, 2022 that may be closed by this pull request
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks merged commit 4107aa3 into main Aug 18, 2022
@CatiaBarroco-xgeeks CatiaBarroco-xgeeks deleted the fix/new-user-permissions branch August 18, 2022 10:34
f-morgado added a commit that referenced this pull request Aug 23, 2022
* test: user role and ownership of boards when deleting

* test: user roles and admin permissions to delete boards

* test: change typeof to boolean on usersuper admin

* feat: delete permissions for users

* feat: delete permissions for users frontend

* fix: pr suggestions

Co-authored-by: Catia Barroco <104831678+CatiaBarroco-xgeeks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: Users permissions to delete boards [BUG]: New user permissions
3 participants