Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: User vote count limit on a specific board verification #414

Merged
merged 10 commits into from
Aug 25, 2022
Merged

[FEATURE]: User vote count limit on a specific board verification #414

merged 10 commits into from
Aug 25, 2022

Conversation

CatiaBarroco-xgeeks
Copy link
Contributor

Relates to #409

Proposed Changes

  • backend protection when user adds votes

Mention people who discussed this issue previously
@f-morgado

This pull request closes #409

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks added this to the MVP milestone Aug 18, 2022
@CatiaBarroco-xgeeks CatiaBarroco-xgeeks linked an issue Aug 18, 2022 that may be closed by this pull request
[FEATURE]: User vote count limit on a specific board verification #409
Closed
nunocaseiro
nunocaseiro previously approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

dsousa12
dsousa12 previously approved these changes Aug 21, 2022
View reviewed changes
backend/src/modules/votes/services/create.vote.service.ts Outdated Show resolved Hide resolved
backend/src/modules/votes/services/create.vote.service.ts Outdated Show resolved Hide resolved
backend/src/modules/votes/services/create.vote.service.ts Outdated Show resolved Hide resolved
backend/src/modules/votes/services/create.vote.service.ts Outdated Show resolved Hide resolved
backend/src/modules/votes/services/create.vote.service.ts Outdated Show resolved Hide resolved
backend/src/modules/votes/services/create.vote.service.ts Outdated Show resolved Hide resolved
frontend/src/components/Board/Card/CardFooter.tsx Outdated Show resolved Hide resolved
dsousa12
dsousa12 previously approved these changes Aug 23, 2022
View reviewed changes
backend/src/modules/votes/services/create.vote.service.ts Outdated Show resolved Hide resolved
mourabraz
mourabraz approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@mourabraz mourabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@f-morgado f-morgado merged commit 55dc6dd into main Aug 25, 2022
@f-morgado f-morgado deleted the feat/user-vote-limit-verification branch August 25, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourabraz mourabraz mourabraz approved these changes

@nunocaseiro nunocaseiro nunocaseiro left review comments

@dsousa12 dsousa12 Awaiting requested review from dsousa12

Assignees

@f-morgado f-morgado

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks

Labels
authentication backend
Projects
SPLIT • Backend
Status: Done
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

[FEATURE]: User vote count limit on a specific board verification
5 participants
@CatiaBarroco-xgeeks @mourabraz @nunocaseiro @dsousa12 @f-morgado