Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: unmerge cards and remaining votes #565

Merged
merged 3 commits into from
Nov 9, 2022
Merged

[Fix]: unmerge cards and remaining votes #565

merged 3 commits into from
Nov 9, 2022

Conversation

nunocaseiro
Copy link
Contributor

Fixes #552

Proposed Changes

  • Fix unmerge optimistic update
  • Fix the cancel button, should return to the previous page - not only to boards list
  • Add remaining votes toast info when the board has a vote limit

This pull request closes #552

@nunocaseiro nunocaseiro requested a review from a team November 8, 2022 21:51
@nunocaseiro nunocaseiro changed the title [Fix]: details [Fix]: unmerge and remaining votes Nov 8, 2022
@nunocaseiro nunocaseiro changed the title [Fix]: unmerge and remaining votes [Fix]: unmerge cards and remaining votes Nov 8, 2022
CatiaAntunes96
CatiaAntunes96 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@CatiaAntunes96 CatiaAntunes96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro nunocaseiro merged commit 300d3d9 into main Nov 9, 2022
@nunocaseiro nunocaseiro deleted the fix/details branch November 9, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatiaAntunes96 CatiaAntunes96 CatiaAntunes96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Stakeholder should not be included in sub-boards
2 participants
@nunocaseiro @CatiaAntunes96