Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issues): unauthorised login error, create card with user, change responsible slack message #582

Merged
merged 3 commits into from
Nov 16, 2022
Merged

fix(issues): unauthorised login error, create card with user, change responsible slack message #582

merged 3 commits into from
Nov 16, 2022

Conversation

nunocaseiro
Copy link
Contributor

Fixes #578

Proposed Changes

  • Fix unauthorised login error
  • Optimistic create card with a user
  • Change responsible slack message only when the responsible was changed

This pull request closes #578

@nunocaseiro nunocaseiro self-assigned this Nov 15, 2022
miguel-felix1
miguel-felix1 previously approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@miguel-felix1 miguel-felix1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro nunocaseiro merged commit ea5e810 into main Nov 16, 2022
@nunocaseiro nunocaseiro deleted the fix/issues branch November 16, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguel-felix1 miguel-felix1 miguel-felix1 approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Sub-board name/configs update sends Slack message
2 participants
@nunocaseiro @miguel-felix1