Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login form, merge board slack msg, create board name error, handle votes #590

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

nunocaseiro
Copy link
Contributor

Fixes #579
Fixes #581
Fixes #589
Fixes #588

Proposed Changes

  • Change login form top space
  • Re-add user avatar tooltip on hover when the user isn't on the board page
  • Add elipsis tex-overflow on the sub board title
  • Add red color in the create board name textfield

This pull request closes #579
This pull request closes #581
This pull request closes #589
This pull request closes #588

@miguel-felix1
Copy link
Contributor

Rightmost avatar popup arrow is out of place
Screenshot 2022-11-16 at 18 44 45

mourabraz
mourabraz previously approved these changes Nov 17, 2022
Copy link
Contributor

@mourabraz mourabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🚀

@miguel-felix1
Copy link
Contributor

Text overflow bug was actually a bug with the word "board" being cut off 😅
Screenshot 2022-11-16 at 18 55 18

Background image on login is still cut off on default Mac resolutions
Screenshot 2022-11-17 at 09 12 02

Copy link
Contributor

@miguel-felix1 miguel-felix1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro nunocaseiro merged commit 33b933e into main Nov 17, 2022
@nunocaseiro nunocaseiro deleted the fix/issues branch November 17, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants