Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user card actions #658

Merged
merged 17 commits into from
Dec 14, 2022
Merged

feat: user card actions #658

merged 17 commits into from
Dec 14, 2022

Conversation

RafaelSBatista97
Copy link
Contributor

#599

Relates to #594

Screenshots (if visual changes)

As Super Admin:
image

As member:
image

Proposed Changes

  • As a super admin the switch button should be visible and editable. This action makes a request to the backend in order to change the user role in the app.
  • The edit button and when the user clicks in the user's name should redirect to the user details.
  • The delete button should be present and this will be done in issue [FEATURE]: Delete user #600.
  • Both icons and user's name must have a hover behaviour.
  • A member only sees the user teams count and which user is an admin.

Mention people who discussed this issue previously
@GuiSanto

This pull request closes #599

@RafaelSBatista97 RafaelSBatista97 added this to the Full Version milestone Dec 6, 2022
rpvsilva
rpvsilva approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

rpvsilva
rpvsilva previously approved these changes Dec 9, 2022
View reviewed changes
rpvsilva
rpvsilva previously approved these changes Dec 12, 2022
View reviewed changes
nunocaseiro
nunocaseiro approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RafaelSBatista97 RafaelSBatista97 merged commit 098dd34 into main Dec 14, 2022
@RafaelSBatista97 RafaelSBatista97 deleted the feat/user-card-actions branch December 14, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

@rpvsilva rpvsilva rpvsilva left review comments

@GuiSanto GuiSanto Awaiting requested review from GuiSanto

Assignees

@GuiSanto GuiSanto

@RafaelSBatista97 RafaelSBatista97

Labels
backend enhancement New feature or request frontend
Projects
SPLIT • Backend
Status: Done
SPLIT • Frontend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[FEATURE]: User card actions
4 participants
@RafaelSBatista97 @rpvsilva @nunocaseiro @GuiSanto