Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: large cards #659

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: large cards #659

merged 1 commit into from
Dec 6, 2022

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Dec 6, 2022 •
edited
Loading

Fixes #656

Proposed Changes

  • Fix large cards
  • Add word break and white-space css prop in the comments and in the cards text

This pull request closes #656

@nunocaseiro nunocaseiro self-assigned this Dec 6, 2022
@nunocaseiro nunocaseiro added the bug Something isn't working label Dec 6, 2022
@miguel-felix1
Copy link
Contributor

Missing white-space: pre in case users actually want to create line breaks

@miguel-felix1
Copy link
Contributor

LGTM 🚀

@nunocaseiro nunocaseiro merged commit ead06d7 into main Dec 6, 2022
@nunocaseiro nunocaseiro deleted the fix/large-cards branch December 6, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguel-felix1 miguel-felix1 miguel-felix1 approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Card length
2 participants
@nunocaseiro @miguel-felix1