Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change team on create board #667

Merged
merged 10 commits into from
Dec 14, 2022
Merged

feat: change team on create board #667

merged 10 commits into from
Dec 14, 2022

Conversation

CatiaAntunes96
Copy link
Contributor

@CatiaAntunes96 CatiaAntunes96 commented Dec 12, 2022 •
edited
Loading

Relates to #663
Fixes #577
Fixes #580

Screenshots (if visual changes)

image

Proposed Changes

  • Add a select with teams that the user is part of. If the user is super Admin, he can view all the teams.
  • When the user selects a team, it's validated if he is a team admin, a stakeholder or super admin, and if the team has the minimum number of members to form subteams. If one of this conditions fails, a message error is displayed and the user can select another team.
  • The joi schema validates if a team is selected. This prevents the user of creating a board without a team, if he clicks on the create button.
  • Fix: Remove error message when the page is refreshed.
  • Fix: Cancel board create button bug fixed. The button is always accessible to the user.
  • Fix: Max Votes input only accepts integers

This pull request closes #663 #577 #580

@CatiaAntunes96 CatiaAntunes96 added enhancement New feature or request frontend labels Dec 12, 2022
@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Dec 12, 2022
@CatiaAntunes96 CatiaAntunes96 self-assigned this Dec 12, 2022
nunocaseiro
nunocaseiro approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🔥 🚀

@CatiaAntunes96 CatiaAntunes96 merged commit dbc9696 into main Dec 14, 2022
@CatiaAntunes96 CatiaAntunes96 deleted the feat/change-team-on-create-board branch December 14, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
enhancement New feature or request frontend
Projects
SPLIT • Frontend
Status: Done
Milestone
Full Version
2 participants
@CatiaAntunes96 @nunocaseiro