Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: select all team members button #673

Merged
merged 12 commits into from
Dec 16, 2022
Merged

feat: select all team members button #673

merged 12 commits into from
Dec 16, 2022

Conversation

patricia-mdias
Copy link
Contributor

Relates to #669
Fixes #670

Screenshots (if visual changes)

75564F22-7369-4E67-933C-C40D956B83C0
54C1F62B-4B91-49FB-B00D-5FD69DF0B186
D6BB7A19-034A-4C3F-B638-AB07DDE5B4D8

Proposed Changes

  • Select all button to select all users of the system.
  • Select all button disappears when searching by name/email, because this button will select all the users and not the users seen when filtering.
  • Search user by full name and email.

@CatiaAntunes96

This pull request closes #669 and #670

@patricia-mdias patricia-mdias added bug Something isn't working enhancement New feature or request frontend labels Dec 13, 2022
@patricia-mdias patricia-mdias added this to the Full Version milestone Dec 13, 2022
@patricia-mdias patricia-mdias self-assigned this Dec 13, 2022
@patricia-mdias patricia-mdias marked this pull request as draft December 13, 2022 16:33
@patricia-mdias patricia-mdias marked this pull request as ready for review December 16, 2022 12:52
nunocaseiro
nunocaseiro approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@patricia-mdias patricia-mdias merged commit 443e9a9 into main Dec 16, 2022
@patricia-mdias patricia-mdias deleted the feat/select-all-team-members-button branch December 16, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@patricia-mdias patricia-mdias

Labels
bug Something isn't working enhancement New feature or request frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: fix search user on teams [FEATURE]: Select all team members button
2 participants
@patricia-mdias @nunocaseiro