Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: voting updates #711

Merged
merged 3 commits into from
Dec 19, 2022
Merged

fix: voting updates #711

merged 3 commits into from
Dec 19, 2022

Conversation

nunocaseiro
Copy link
Contributor

Fixes #710

Proposed Changes

  • Return board users data on voting updates
  • Change the voting optimistic updates

This pull request closes #710

@nunocaseiro nunocaseiro self-assigned this Dec 19, 2022
@nunocaseiro nunocaseiro added bug Something isn't working frontend labels Dec 19, 2022
@nunocaseiro nunocaseiro requested a review from a team December 19, 2022 11:34
rpvsilva
rpvsilva requested changes Dec 19, 2022
View reviewed changes
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion, but LGTM

frontend/src/hooks/useVotes.tsx Outdated Show resolved Hide resolved
@nunocaseiro nunocaseiro merged commit 21c9128 into main Dec 19, 2022
@nunocaseiro nunocaseiro deleted the fix/votes branch December 19, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpvsilva rpvsilva rpvsilva approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: votes in card items. performance
2 participants
@nunocaseiro @rpvsilva