Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get teams of user backend refactored #728

Merged
merged 2 commits into from
Dec 22, 2022
Merged

feat: get teams of user backend refactored #728

merged 2 commits into from
Dec 22, 2022

Conversation

GuiSanto
Copy link
Contributor

Relates to #594

Proposed Changes

  • refactored the backend of "get teams of user" in order to work with any user. Previously the controller only received the ID from the session.

This pull request closes #715 #717

@GuiSanto GuiSanto added this to the Full Version milestone Dec 21, 2022
rpvsilva
rpvsilva previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 just a simple change

backend/src/libs/dto/param/user.teams.param.ts Outdated Show resolved Hide resolved
nunocaseiro
nunocaseiro approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GuiSanto GuiSanto merged commit 5e9f54c into main Dec 22, 2022
@GuiSanto GuiSanto deleted the feat/fetch-teams-of-user-backend branch December 22, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

@rpvsilva rpvsilva rpvsilva left review comments

Assignees

@GuiSanto GuiSanto

@RafaelSBatista97 RafaelSBatista97

Labels
backend
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Fetch all teams of a user
4 participants
@GuiSanto @rpvsilva @nunocaseiro @RafaelSBatista97