Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter boards by team endpoint #760

Merged
merged 4 commits into from
Dec 29, 2022

Conversation

patricia-mdias
Copy link
Contributor

Relates to #756

Proposed Changes

  • Filter boards by team endpoint (with pagination)

This pull request closes #756

@patricia-mdias patricia-mdias added enhancement New feature or request backend labels Dec 29, 2022
@patricia-mdias patricia-mdias added this to the Full Version milestone Dec 29, 2022
@patricia-mdias patricia-mdias self-assigned this Dec 29, 2022
@patricia-mdias patricia-mdias marked this pull request as draft December 29, 2022 14:57
@patricia-mdias patricia-mdias marked this pull request as ready for review December 29, 2022 15:01
backend/src/modules/boards/controller/boards.controller.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/get.board.service.ts Outdated Show resolved Hide resolved
frontend/src/api/boardService.tsx Outdated Show resolved Hide resolved
frontend/src/api/boardService.tsx Outdated Show resolved Hide resolved
rpvsilva
rpvsilva previously approved these changes Dec 29, 2022
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

@patricia-mdias
Copy link
Contributor Author

I don't understand why the frontend build fails, since I didn't change the files the build is complaining. However, I checked those files, ran the build locally and everything looks fine.

@rpvsilva rpvsilva force-pushed the feat/filter-boards-by-team-be branch from e7f98a8 to 6bc071e Compare December 29, 2022 17:01
@rpvsilva
Copy link
Member

I've just rebased with the main and fixed the issue, the problem was with the last commit to the main.

@patricia-mdias patricia-mdias merged commit 083f45d into main Dec 29, 2022
@patricia-mdias patricia-mdias deleted the feat/filter-boards-by-team-be branch December 29, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Filter boards by team
2 participants