Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docker compose and docker files for each app #77

Merged
merged 23 commits into from
Feb 8, 2022

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Feb 1, 2022

Relates to #38

Proposed Changes

  • Docker file for each application
  • Implemented the service to each application in Docker compose

@all-contributors please add @nunocaseiro for code, test, infrastructure and doc

This pull request is intended to close #38

Copy link

@serrovsky serrovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes that don't seem to be related. Am I seeing it right? For example backend/src/auth/auth.service.ts file was a lot of changes 😕

@nunocaseiro
Copy link
Contributor Author

There are a lot of changes that don't seem to be related. Am I seeing it right? For example backend/src/auth/auth.service.ts file was a lot of changes 😕

Yes, they are small changes and test fixes. There are no new logic/features or something like that :)

serrovsky
serrovsky previously approved these changes Feb 2, 2022
@nunocaseiro nunocaseiro merged commit 9321176 into xgeekshq:main Feb 8, 2022
@nunocaseiro
Copy link
Contributor Author

@all-contributors please add @nunocaseiro for code, test, infrastructure and doc

@allcontributors
Copy link
Contributor

@nunocaseiro

I've put up a pull request to add @nunocaseiro! 🎉

nunocaseiro added a commit to nunocaseiro/split that referenced this pull request Feb 11, 2022
@nunocaseiro nunocaseiro deleted the docker-prod branch November 18, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Create Docker image for each project and docker-compose
2 participants