Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update card position and votes with sockets #827

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Jan 7, 2023

Fixes #825

Proposed Changes

Note: this should solve the majority of issues regarding performance when many people are moving or voting the cards in real-time. This should be tested in the live version

  • When voting in a card or moving its position now a socket message is sent to all users that are seeing the board and receiving that they will update the board locally instead of making a board request
  • If some error occurs in the backend during these updates a message is sent to all users to refetch the board. (this may not be necessary)

This pull request closes #825

@nunocaseiro nunocaseiro added bug Something isn't working frontend backend labels Jan 7, 2023
@nunocaseiro nunocaseiro added this to the Full Version milestone Jan 7, 2023
@nunocaseiro nunocaseiro self-assigned this Jan 7, 2023
@nunocaseiro nunocaseiro requested review from rpvsilva and a team January 7, 2023 00:53
@nunocaseiro nunocaseiro requested a review from rpvsilva January 7, 2023 14:17
@nunocaseiro nunocaseiro merged commit 9dd7623 into main Jan 7, 2023
@nunocaseiro nunocaseiro deleted the fix/socket branch January 7, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: board performance issues
2 participants