Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce number of requests using sockets #837

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

rpvsilva
Copy link
Member

@rpvsilva rpvsilva commented Jan 9, 2023

This PR decreases the number of requests when user A adds/updates/deletes cards and user B has to update the application. Also, it reduces the requests for comments

@rpvsilva rpvsilva requested a review from nunocaseiro January 9, 2023 13:10
@rpvsilva rpvsilva self-assigned this Jan 9, 2023
@rpvsilva rpvsilva marked this pull request as ready for review January 9, 2023 13:10
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rpvsilva rpvsilva merged commit 11d1595 into main Jan 9, 2023
@rpvsilva rpvsilva deleted the feat/refactor-too-many-requests branch January 9, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants