Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug sub board configurations #856

Merged
merged 7 commits into from
Jan 16, 2023
Merged

Conversation

jpvsalvador
Copy link
Contributor

Relates to #844
Fixes #844

Screenshots

image

image

image

Proposed Changes

  • Allow user to remove the input (allow backspaces)
  • Validate if input is between min and max
  • Only allow the user to submit if the inputs are valid

This pull request closes #844

nunocaseiro
nunocaseiro previously approved these changes Jan 13, 2023
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

rpvsilva
rpvsilva previously approved these changes Jan 13, 2023
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

nunocaseiro
nunocaseiro previously approved these changes Jan 13, 2023
@jpvsalvador jpvsalvador merged commit bb4a989 into main Jan 16, 2023
@jpvsalvador jpvsalvador deleted the 844-bug-sub-board-configurations branch January 16, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: sub-board configurations
4 participants