Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug drop down design #872

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: bug drop down design #872

merged 2 commits into from
Jan 16, 2023

Conversation

StereoPT
Copy link
Contributor

Relates to #869
Fixes #869

Screenshots (if visual changes)

  • Filters now have a White Background, as shown in the design documents

image

  • Dropdown options cursor is now a pointer.
  • Dropdown "menu" has a 12px rounded border
  • Dropdown options selected and hover background color fixed

image

This pull request closes #869

@StereoPT StereoPT added bug Something isn't working frontend labels Jan 16, 2023
@StereoPT StereoPT requested a review from a team January 16, 2023 14:32
@StereoPT StereoPT self-assigned this Jan 16, 2023
@StereoPT StereoPT linked an issue Jan 16, 2023 that may be closed by this pull request
[BUG]: drop-down design #869
Closed
CatiaAntunes96
CatiaAntunes96 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@CatiaAntunes96 CatiaAntunes96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@StereoPT StereoPT merged commit c4524d2 into main Jan 16, 2023
@StereoPT StereoPT deleted the 869-bug-drop-down-design branch January 16, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatiaAntunes96 CatiaAntunes96 CatiaAntunes96 approved these changes

Assignees

@StereoPT StereoPT

@jpvsalvador jpvsalvador

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: drop-down design
3 participants
@StereoPT @CatiaAntunes96 @jpvsalvador