Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search input clear and colors #876

Merged
merged 3 commits into from
Jan 17, 2023
Merged

fix: search input clear and colors #876

merged 3 commits into from
Jan 17, 2023

Conversation

jpvsalvador
Copy link
Contributor

Relates to #874
Fixes #874

Screenshots

image

Proposed Changes

  • Add clear feature to search input
  • Change search icon color to dark gray

This pull request closes #874

@jpvsalvador jpvsalvador added bug Something isn't working frontend labels Jan 16, 2023
@jpvsalvador jpvsalvador requested a review from a team January 16, 2023 16:00
@jpvsalvador jpvsalvador linked an issue Jan 16, 2023 that may be closed by this pull request
[BUG]: search input redesign #874
Closed
nunocaseiro
nunocaseiro previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jpvsalvador jpvsalvador marked this pull request as draft January 17, 2023 10:16
@jpvsalvador jpvsalvador marked this pull request as ready for review January 17, 2023 10:17
@jpvsalvador jpvsalvador merged commit 4be488b into main Jan 17, 2023
@jpvsalvador jpvsalvador deleted the 874-bug-search-input-redesign branch January 17, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@StereoPT StereoPT

@jpvsalvador jpvsalvador

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: search input redesign
3 participants
@jpvsalvador @nunocaseiro @StereoPT