Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set check value only on slackEnable #948

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix: set check value only on slackEnable #948

merged 1 commit into from
Jan 27, 2023

Conversation

jpvsalvador
Copy link
Contributor

Relates to #934
Fixes #934

Screenshots

image

Proposed Changes

  • Set check value only on slackEnable (so it is persistent when changing tabs when creating a board but doesn't affect the behaviour of the checkbox on other components)

This pull request closes #934

@jpvsalvador jpvsalvador added bug Something isn't working frontend labels Jan 27, 2023
@jpvsalvador jpvsalvador requested a review from a team January 27, 2023 09:22
@jpvsalvador jpvsalvador self-assigned this Jan 27, 2023
@jpvsalvador jpvsalvador linked an issue Jan 27, 2023 that may be closed by this pull request
[BUG] Anonymous checkmark #934
Closed
StereoPT
StereoPT approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@StereoPT StereoPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗝

@jpvsalvador jpvsalvador merged commit 886bbb6 into main Jan 27, 2023
@jpvsalvador jpvsalvador deleted the 934-bug-anonymous-checkmark branch January 27, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StereoPT StereoPT StereoPT approved these changes

Assignees

@jpvsalvador jpvsalvador

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Anonymous checkmark
2 participants
@jpvsalvador @StereoPT