Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings in a split board #955

Merged
merged 2 commits into from
Jan 30, 2023
Merged

fix: settings in a split board #955

merged 2 commits into from
Jan 30, 2023

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Jan 28, 2023 •
edited
Loading

Fixes #954

Proposed Changes

  • Board settings component now handles if it's a split or regular board

This pull request closes #954

@nunocaseiro nunocaseiro added bug Something isn't working frontend labels Jan 28, 2023
@nunocaseiro nunocaseiro added this to the Full Version milestone Jan 28, 2023
@nunocaseiro nunocaseiro self-assigned this Jan 28, 2023
patricia-mdias
patricia-mdias reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@patricia-mdias patricia-mdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@nunocaseiro nunocaseiro merged commit 54c078e into main Jan 30, 2023
@nunocaseiro nunocaseiro deleted the fix/board-configurations branch January 30, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricia-mdias patricia-mdias patricia-mdias approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: split board settings
2 participants
@nunocaseiro @patricia-mdias