Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added s parameter to neighbors #450

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Added s parameter to neighbors #450

merged 2 commits into from
Sep 22, 2023

Conversation

nwlandry
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (290729a) 91.84% compared to head (ac0dccf) 91.90%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   91.84%   91.90%   +0.06%     
==========================================
  Files          60       60              
  Lines        4255     4375     +120     
==========================================
+ Hits         3908     4021     +113     
- Misses        347      354       +7     
Files Changed Coverage Δ
xgi/core/views.py 94.11% <100.00%> (+0.06%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximelucas
Copy link
Collaborator

maximelucas commented Aug 18, 2023

Nice. Maybe add tests?
(Edit: Oops sorry didn't see it was still a draft)

@nwlandry nwlandry marked this pull request as ready for review September 21, 2023 19:09
@nwlandry nwlandry merged commit 83e9e4a into main Sep 22, 2023
18 checks passed
@nwlandry nwlandry deleted the add-neighbor-functionality branch September 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants