-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom filterby #524
Custom filterby #524
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
+ Coverage 92.05% 92.20% +0.15%
==========================================
Files 60 60
Lines 4381 4389 +8
==========================================
+ Hits 4033 4047 +14
+ Misses 348 342 -6 ☔ View full report in Codecov by Sentry. |
@nwlandry thanks, I will review this during the afternoon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only found to minor things in the new recipe (changes in the comments to the code + execute the cells so that we see the outputs). The rest looks good. Thank you!
Thanks so much, @thomasrobiglio, for the helpful review! I have made all the requested changes and I plan on merging once the tests all pass! |
Added the ability for users to define their own functions of the form
f(val, arg)
to add flexibility tofilterby
andfilterby_attr
.