Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filterby #524

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Custom filterby #524

merged 5 commits into from
Mar 13, 2024

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Mar 9, 2024

Added the ability for users to define their own functions of the form f(val, arg) to add flexibility to filterby and filterby_attr.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nwlandry nwlandry mentioned this pull request Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (4667614) to head (33612b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   92.05%   92.20%   +0.15%     
==========================================
  Files          60       60              
  Lines        4381     4389       +8     
==========================================
+ Hits         4033     4047      +14     
+ Misses        348      342       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry requested a review from thomasrobiglio March 11, 2024 17:52
@nwlandry nwlandry linked an issue Mar 11, 2024 that may be closed by this pull request
@thomasrobiglio
Copy link
Collaborator

@nwlandry thanks, I will review this during the afternoon!

Copy link
Collaborator

@thomasrobiglio thomasrobiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only found to minor things in the new recipe (changes in the comments to the code + execute the cells so that we see the outputs). The rest looks good. Thank you!

@nwlandry
Copy link
Collaborator Author

Thanks so much, @thomasrobiglio, for the helpful review! I have made all the requested changes and I plan on merging once the tests all pass!

@nwlandry nwlandry merged commit d6c9944 into main Mar 13, 2024
24 checks passed
@nwlandry nwlandry deleted the custom-filterby branch March 13, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more statistics functionality
2 participants