feat: hypergraph random edge shuffle #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwlandry
reviewed
Apr 5, 2024
nwlandry
reviewed
Apr 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
+ Coverage 92.12% 92.16% +0.04%
==========================================
Files 60 60
Lines 4393 4417 +24
==========================================
+ Hits 4047 4071 +24
Misses 346 346 ☔ View full report in Codecov by Sentry. |
|
Resolved these comments, could you take another look? Thanks. |
|
Looks great! Thanks so much! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
random_edge_shufflefor hypergraphs, as described in Configuration models of random hypergraphs, Philip S C., 2020.Given two edges, the existing
double_edge_swapswaps two nodes, whereasrandom_edge_shuffleputs all nodes in a bucket and shuffles them.This preserves the edge sizes and node degrees.
If the same node appears in both hyperedges, then this is still true after reshuffling.
The user can also use this to shuffle two randomly selected hyperedges, if no edge IDs are specified.