Added edge_ec argument in draw to specify edge colors
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 92.51% 93.13% +0.62%
==========================================
Files 59 60 +1
Lines 4393 4503 +110
==========================================
+ Hits 4064 4194 +130
+ Misses 329 309 -20 ☔ View full report in Codecov by Sentry. |
… still had old plotting defaults
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
nwlandry
approved these changes
Aug 30, 2024
| @@ -103,8 +103,8 @@ def _parse_color_arg(colors, ids, id_kind="edges"): | |||
| -------- | |||
| colors : single color or ndarray | |||
| Processed color values for plotting. | |||
| colors_are_mapped : bool | |||
| True if the colors are mapped and need special handling. This | |||
| colors_to_map : bool | |||
There was a problem hiding this comment.
can this just be called map_colors?
There was a problem hiding this comment.
Yea that would work too I guess, but the colors are only mapped later in the draw function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #537
Excepted usage is mostly when using
draw()withhull=Trueand white facecolors for edges withedge_fc="white".Colors can be specified in all usual formats (same as
edge_fc).Technical trick: matplotlib does not automatically map numeric values to colors for
edgecolorsinPatchCollectionso I had to map them manually with aScalarMappable. Thevmin,vmax; andcmapused for the mapping are the same as those fromedge_fc.