Integrate optional plotting capabilities into ashist() #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: Added function to core.py to best understand the workflow
…ns when a pull request is made
|
@willcollins10 --- thanks for the PR! I will try to take a look this afternoon! |
|
@willcollins10 --- side note, the tests fail because the example you added in the docstring never defines |
nwlandry
requested changes
Dec 10, 2024
| # Only execute plotting code if plot is True or a string | ||
| if plot: | ||
| try: | ||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
If users have installed xgi, I believe that they will also have matplotlib by default, so not sure that you need to check this.
| df = hist(self.asnumpy(), bins, bin_edges, density, log_binning) | ||
|
|
||
| # Only execute plotting code if plot is True or a string | ||
| if plot: |
There was a problem hiding this comment.
Can you break this out into a modular helper function with an underscore prefix like _plot_hist or similar?
| Originally from https://github.com/jkbren/networks-and-dataviz | ||
| Examples | ||
| -------- | ||
| >>> H.nodes.degree.ashist(plot='bar', plot_kwargs={'color': 'red'}) |
There was a problem hiding this comment.
Define what H is. maybe a small example? like
H = xgi.Hypergraph([[1, 2, 3], [3, 4], [1, 3, 6]])
H.nodes.degree.ashist(plot='bar', plot_kwargs={'color': 'red'})| fig, ax = plt.subplots() | ||
|
|
||
| # Plot based on type | ||
| if plot_type == "bar": |
There was a problem hiding this comment.
can you add a "scatter" option or replace the "line" option with a scatterplot only plotting the points?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates optional plotting capabilities directly into the
ashist()function. Users can now generate plots ('bar','line', or'step') by setting theplotparameter toTrueand customize plot appearance usingplot_kwargs.Changes Made
plotandplot_kwargsparameters to theashist()function.matplotlib.pyplotbased on the specified plot type.bin_edgesisTrue.Testing
plot_kwargs.densityandbin_edges.Related Issues
Closes #<606>