Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with load_xgi_data HIF #637

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix issue with load_xgi_data HIF #637

merged 1 commit into from
Dec 10, 2024

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Dec 10, 2024

This PR

  • fixes an error where load_xgi_data can't load HIF-format files.
  • Adds corresponding unit tests to make sure that this doesn't happen again.
  • Renames G to H

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (ade37fb) to head (cec3af9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   93.36%   93.43%   +0.06%     
==========================================
  Files          64       64              
  Lines        4962     4962              
==========================================
+ Hits         4633     4636       +3     
+ Misses        329      326       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry merged commit 943b64a into main Dec 10, 2024
24 checks passed
@nwlandry nwlandry deleted the fix-load-xgi-data branch December 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant