Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changelog generator #639

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Improve changelog generator #639

merged 2 commits into from
Dec 20, 2024

Conversation

nwlandry
Copy link
Collaborator

Fixes #627. This uses the fact that issues are auto-closed by GitHub and if an issue is closed within 2 seconds of a PR being merged than the issue is considered associated with the PR. There are obvious ways to break this, but should work 99.5% of the time :)

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (a549885) to head (a0d4d64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          64       64           
  Lines        4966     4966           
=======================================
  Hits         4640     4640           
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximelucas
Copy link
Collaborator

Thanks so much Nich!
If there's a reference that you used for this (like the GraphQL API you mentioned in the associated issue), could you link it here for future ref?

@nwlandry
Copy link
Collaborator Author

Thanks for the review, @maximelucas! I used a lot of the internals from the git-changelog package.

@nwlandry nwlandry merged commit ddc5cbb into main Dec 20, 2024
24 checks passed
@nwlandry nwlandry deleted the improve-changelog-generator branch December 20, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically add issue numbers closed by PRs
2 participants