Skip to content

Commit

Permalink
Ensure upgrade prompt shown by connected clients after first v21.x re…
Browse files Browse the repository at this point in the history
…lease

+ At release time, connected clients will be running an older version of hoist-react that looks for upgrade instructions in the `/xh/version` output. Temporarily restore that key to bridge the gap/
  • Loading branch information
amcclain committed Sep 5, 2024
1 parent d2abf53 commit 9c6a442
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
# Changelog

## 22.0-SNAPSHOT - unreleased
## 21.0.1 - 2024-09-05

### 🐞 Bug Fixes

* Resolved issue where connected clients would not display the upgrade prompt banner when an app was
first released with an update to `hoist-core >= 21.0.0`.

### ⚙️ Technical
* Improvements to serialization efficiency of replicated `Cache` and `CachedValue`

* Improved serialization efficiency of replicated `Cache` and `CachedValue`.

## 21.0.0 - 2024-09-03

Expand Down
7 changes: 6 additions & 1 deletion grails-app/controllers/io/xh/hoist/impl/XhController.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,12 @@ class XhController extends BaseController {
appVersion: Utils.appVersion,
appBuild: Utils.appBuild,
timestamp: System.currentTimeMillis(),
success: true
success: true,
// TODO - this is a temporary measure to ensure that clients running hoist-react < 67
// prompt for upgrade when a new app release is deployed with hoist-core >= 21.
// Going forward clients will read these instructions from `xh/environmentPoll`.
// Once a majority of key apps have been upgraded, we should remove this key.
mode: configService.getMap('xhEnvPollConfig').onVersionChange
)
}

Expand Down

0 comments on commit 9c6a442

Please sign in to comment.