Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseUserService now allows app implementation to use the app's User type #360

Merged
merged 1 commit into from
May 22, 2024

Conversation

jskupsik
Copy link
Contributor

Currently, BaseUserService does not allow the implementation to use it's own User:

class AppUser extends HoistUser { ... 
class UserService extends BaseUserService {
    // This does not build, because the return type of `List<AppUser> ` is incompatible with `List<HoistUser>`
    @Override
    List<AppUser> list(boolean activeOnly) { ... 

With this fix, the app's UserService is allowed to type its own methods.

@jskupsik
Copy link
Contributor Author

Toolbox branch, which shows an implementation that now works due to this fix - xh/toolbox#720

@lbwexler lbwexler merged commit 51b3e97 into develop May 22, 2024
4 checks passed
@lbwexler lbwexler deleted the baseUserServiceTypeFix branch May 22, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants