Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LdapService & LdapPerson Improvements #362

Merged
merged 2 commits into from
Jun 19, 2024
Merged

LdapService & LdapPerson Improvements #362

merged 2 commits into from
Jun 19, 2024

Conversation

cnrudd
Copy link
Member

@cnrudd cnrudd commented Jun 18, 2024 •
edited
Loading

🎁 New Features

  • LdapService searchOne and searchMany methods have been made public.
  • LdapPerson class now includes displayName, givenname, and sn fields.

🐞 Bug Fixes

  • LdapPerson class email key changed to mail to match LDAP attribute.

This branch's changes have been tested in a client app that needed these changes.

@cnrudd cnrudd changed the title Ldap adjustments LdapService & LdapPerson Improvements Jun 18, 2024
@cnrudd cnrudd requested a review from lbwexler June 18, 2024 22:03
@lbwexler
Copy link
Member

Nice! Will adjust changelog in develop

@lbwexler lbwexler merged commit 1e3a6f0 into develop Jun 19, 2024
5 checks passed
@lbwexler lbwexler deleted the ldapAdjustments branch June 19, 2024 12:14
@cnrudd cnrudd mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbwexler lbwexler lbwexler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnrudd @lbwexler