Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin log levels configuration grid does not refresh after update #3800

Closed
amcclain opened this issue Oct 3, 2024 · 2 comments · Fixed by #3801
Closed

Admin log levels configuration grid does not refresh after update #3800

amcclain opened this issue Oct 3, 2024 · 2 comments · Fixed by #3801

Comments

@amcclain
Copy link
Member

amcclain commented Oct 3, 2024

When adding or updating a log level, the entire grid should refresh after any individual update, to reflect potential changes to effective logging levels on other rows.

Eg I have log level rows for com.myapp and com.myapp.pkg. Both start with no override showing default INFO level. I update parent com.myapp to debug. After update com.myapp.pkg should also show effective level of debug.

If after making that update I close the log levels dialog and re-open, I see the correct effective levels across all rows.

@lbwexler
Copy link
Member

lbwexler commented Oct 4, 2024

Yes, of course, agree that really is important and would really aid in understanding how this works.

Looked at it, and weirdly we don't have any great hooks for this in RestGridModel.

@lbwexler lbwexler linked a pull request Oct 4, 2024 that will close this issue
6 tasks
@lbwexler
Copy link
Member

lbwexler commented Oct 4, 2024

actual found a little workaround see PR -- think making RestGridModel more flexible to handle this is a bigger project, but felt it was worth it to get this fix in ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants