Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all log levels when a single row is changed #3801

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Oct 4, 2024

Threw in a Refresh button to our RestGrid for good measure -- hope that makes sense? Obviously not attached to that.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler linked an issue Oct 4, 2024 that may be closed by this pull request
@lbwexler lbwexler merged commit 9f865a5 into develop Oct 4, 2024
2 checks passed
@lbwexler lbwexler deleted the refreshAllLogs branch October 4, 2024 22:33
@amcclain
Copy link
Member

amcclain commented Oct 8, 2024

Hi @lbwexler - thanks for this - sorry for not getting to review in a more timely manner- was on my list!

I wanted to check in re. addition of the refresh button to RestGrid, without any optionality on it. We end up with this "double refresh button" in a few places in the admin app, and I know we have several client apps that also have full-tab rest grids that will render the same, with the new refresh button right by the app refresh:

Screenshot 2024-10-08 at 2 42 29 PM

I think I would have voted to make this opt-in, so a dev could turn it on for a case like the log levels grid while the base case didn't change. WDYY?

@lbwexler
Copy link
Member Author

lbwexler commented Oct 8, 2024

Agree its a problem - will make it optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin log levels configuration grid does not refresh after update
2 participants