Extending to Non-ASCII characters with corpora loading and saving #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhluca
approved these changes
Dec 23, 2024
|
I have not ran this locally, however the updated tests look good and all the checks have passed, so merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observation: After saving the indices along with the corpus.json, it was unable to load if the corpora contain Non-ASCII character and was throwing error:
In a similar PR Added support for saving and loading non ASCII chars in corpus and vocab #86, it was done for vocab but corpus saving was missed.
Changes made in the PR:
-> Added json_functions ensure_ascii = False while saving when corpus is also supplied.
-> Added encoding='utf-8' for ensuring uniformity across different systems.
-> Modified the unit test cases to support the above scenario as well.