Add unit test for pandas-dev#12813

xhochy · Jul 8, 2018 · 3c1ccf6 · 3c1ccf6
1 parent 6008d75
commit 3c1ccf6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/doc/source/whatsnew/v0.24.0.txt b/doc/source/whatsnew/v0.24.0.txt
@@ -331,6 +331,7 @@ Numeric
 ^^^^^^^
 
 - Bug in :class:`Series` ``__rmatmul__`` doesn't support matrix vector multiplication (:issue:`21530`)
+- Bug in :func:`factorize` fails with read-only array (:issue:`12813`)
 -
 -
 

diff --git a/pandas/tests/test_algos.py b/pandas/tests/test_algos.py
@@ -231,8 +231,9 @@ def test_complex_sorting(self):
 
         pytest.raises(TypeError, algos.factorize, x17[::-1], sort=True)
 
-    def test_uint64_factorize(self):
+    def test_uint64_factorize(self, writable):
         data = np.array([2**63, 1, 2**63], dtype=np.uint64)
+        data.setflags(write=writable)
         exp_labels = np.array([0, 1, 0], dtype=np.intp)
         exp_uniques = np.array([2**63, 1], dtype=np.uint64)
-Original file line number
+Diff line change
@@ Expand Up / @@ -331,6 +331,7 @@ Numeric @@
     ^^^^^^^
     - Bug in :class:`Series` ``__rmatmul__`` doesn't support matrix vector multiplication (:issue:`21530`)
+    - Bug in :func:`factorize` fails with read-only array (:issue:`12813`)
     -
     -
@@ Expand Down @@