Make timezone recipe/lwrp less noisy #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- while plain 'UTC' is used as default, reconfigure tzdata is executed and file content is replaced with 'Etc/UTC' + newline, thus chef is recreating file during next run with 'UTC' again - timezone attribute was never used - /etc/localtime template was replaced with file, it's just one line - new line was added to /etc/localtime
|
@szymonpk thanks, I did notice this for some time but didn't get around to addressing it. Before we get into dialog can you get it to pass the basic travis testing (rubocop)? |
|
Sure, I'll try to do later. |
|
@flaccid builds are passing now. |
flaccid
added a commit
that referenced
this pull request
Apr 16, 2015
Make timezone recipe/lwrp less noisy
|
@szymonpk thanks. I've merged this, however I'd like to test it a bit more before we release a new version. Not sure if a timezone change is working. We'll also add in at least one unit test for it. |
flaccid
added a commit
that referenced
this pull request
Apr 16, 2015
- remove un-needed include_recipe for cron::default as initialization of the resource already does it - remove the default for the timezone attribute of the resource as its a name_attribute - support providing a zone with a space instead of underscore (for the humans) - make before and after tz-info log resources debug log level - fail if an invalid timezone is provided - fix not actually setting the timezone when the user sets system/timezone attribute
|
Ok I have fixed it up now. Now we just need a bunch of tests before we release new version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed race condition between chef-client and reconfigure tzdata, every chef run
/etc/localtimewas recreated and cron restarted. If you accept this I can update metadata.rb.