make it possible to control which phase package upgrades occur #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaccid
added a commit
that referenced
this pull request
Sep 26, 2015
make it possible to control which phase package upgrades occur
|
Perfect! Thanks @jhohertz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, a feature for your consideration.
This one adds a new attribute to additionally control package upgrades. In the current cookbook, this happens at compile time only. This is not always the most desirable thing to happen. (Mostly finding difficulties when trying to run cookbooks that update kernel modules via dkms, which really like the currently running kernel to also be the most recent currently installed)
This leaves the current behaviour as the default, but provides the option of moving upgrade to occur when the include happens, which gives greater control over behaviour when making wrapper cookbooks.
I have not included a test case yet, partly due to the difficulties in testing the nature of this, and partly because the package upgrade path is not a part of the current suite of tests.
Let me know if you'd like to see anything revised in the pull request and I'll make it so.