Feature network restart control #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, the kitchen fails to make a valid Vagrantfile, as it interprets the unquoted string as a regex.
|
@jhohertz had to so some voodoo on that due to a couple of conflicts but the kitchen change I had to reject - its a classic issue but the driver_config/ssh/shell should be fixed upstream; its currently ok in the bento boxes used. |
|
@flaccid thanks, and noted about the kitchen item, will leave such things out in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provides a new attrib to control if network restart initiated by the hostname provider happens in a delayed or immediate manner. the default preserves the existing delayed behaviour while allowing the option to instead ask for an immediate restart should that suit your needs.
a second commit fixes an issue seen while running the test suite where the freebsd platforms was not generating valid Vagrantfiles due to a lack of quoting on shell definitions, causing the vagrant files generated to interpret the string for the shell as a regex instead.