Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChefSpec matchers #42

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Add ChefSpec matchers #42

merged 1 commit into from
Apr 22, 2016

Conversation

szymonpk
Copy link
Contributor

Now, it's possible to test all resources interactions using ChefSpec.

@flaccid
Copy link
Contributor

flaccid commented Apr 21, 2016

Possible to address https://travis-ci.org/xhost-cookbooks/system/jobs/124701545 first?

@flaccid flaccid self-assigned this Apr 21, 2016
@szymonpk
Copy link
Contributor Author

Action is set so with ChefSpec best practices I've seen so far it should be set_system_hostname and set_system_timezone. I'll disable this check in matchers.rb file.

@flaccid
Copy link
Contributor

flaccid commented Apr 22, 2016

You will probably still need to make an exception with rubocop to pass.

Add ChefSpec matchers
42157e5 
It's possible to test all resources using ChefSpec.
@szymonpk
Copy link
Contributor Author

Ok, it's passing all checks now.

@flaccid flaccid merged commit 825898a into xhost-cookbooks:master Apr 22, 2016
@flaccid
Copy link
Contributor

flaccid commented Apr 22, 2016

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flaccid flaccid

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonpk @flaccid