Message is not upgraded if Upgrade header is missing (aio-libs#7895)

xiangxli · Dec 4, 2023 · 1961808 · 1961808
1 parent 30ac983
commit 1961808
Show file tree

Hide file tree

Showing 3 changed files with 124 additions and 97 deletions.
diff --git a/CHANGES/7895.bugfix b/CHANGES/7895.bugfix
@@ -0,0 +1 @@
+Fixed messages being reported as upgraded without an Upgrade header in Python parser. -- by :user:`Dreamsorcerer`
diff --git a/aiohttp/http_parser.py b/aiohttp/http_parser.py
@@ -510,7 +510,8 @@ def parse_headers(
                 close_conn = True
             elif v == "keep-alive":
                 close_conn = False
-            elif v == "upgrade":
+            # https://www.rfc-editor.org/rfc/rfc9110.html#name-101-switching-protocols
+            elif v == "upgrade" and headers.get(hdrs.UPGRADE):
                 upgrade = True
 
         # encoding
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed messages being reported as upgraded without an Upgrade header in Python parser. -- by :user:`Dreamsorcerer`