Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加未实现的功能 #90

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

zzz999
Copy link

@zzz999 zzz999 commented May 12, 2017

完成column的tooltip功能
监听文件变化,自动编译,将dist/wxcharts.js link到wx-charts-demo项目中,实现编译之后刷新看到效果
完成y轴虚线功能,yAxis.lineType='dashed'

@zzz999 zzz999 closed this May 12, 2017
@zzz999 zzz999 reopened this May 12, 2017
@xiaolin3303
Copy link
Owner

首先非常感谢提交你们的代码,我整体看了一遍,存在几个问题
1、修改了系统的一些配置,比如默认的颜色配置以及线宽等;
2、添加虚线部分代码不是很规范,应该把该方法提出来作为一个公用的方法,里面的一些配置也需要提取出来统一管理;
3、column charttooltip的效果不是很好,主要是弹出的位置,需要进一步优化
image

添加rollup watch做法很好,会采纳

建议针对每个小功能单独提pull request,这样比较容易code review以及管理,谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants