Release 6.0.1?

[gruenich]

@xiaoyeli, what do think about releasing the current master as 6.0.1?

The fixed regression #100 would justify the change. Having a proper release would help downstream projects like PETSc.

Further, some of the fixed compiler warnings might be turned into errors with upcoming compiler versions. The improvements to CMake and Doxygen come on top.

[wuch-g2v]

+1

[gruenich]

Thank you for creating a 6.0.1 release! I am on my way to update the openSuse package.

Before I close this issue, could you please update the homepage and mention 6.0.1 there?

[kloczek]

Looks like it some issue with 6.0.1

[ 80%] Building C object EXAMPLE/CMakeFiles/citersol.dir/cfgmr.c.o
cd /home/tkloczko/rpmbuild/BUILD/superlu-6.0.1/x86_64-redhat-linux-gnu/EXAMPLE && /usr/bin/gcc  -I/home/tkloczko/rpmbuild/BUILD/superlu-6.0.1/x86_64-redhat-linux-gnu/SRC -I/home/tkloczko/rpmbuild/BUILD/superlu-6.0.1/SRC -DUSE_VENDOR_BLAS -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -DNDEBUG -std=c99 -MD -MT EXAMPLE/CMakeFiles/citersol.dir/cfgmr.c.o -MF CMakeFiles/citersol.dir/cfgmr.c.o.d -o CMakeFiles/citersol.dir/cfgmr.c.o -c /home/tkloczko/rpmbuild/BUILD/superlu-6.0.1/EXAMPLE/cfgmr.c
/home/tkloczko/rpmbuild/BUILD/superlu-6.0.1/EXAMPLE/cfgmr.c: In function ‘cfgmr’:
/home/tkloczko/rpmbuild/BUILD/superlu-6.0.1/EXAMPLE/cfgmr.c:83:16: error: conflicting types for ‘caxpy_’; have ‘int(int *, complex *, complex *, int *, complex *, int *)’
   83 |     extern int caxpy_(int *, complex *, complex [], int *, complex [], int *);
      |                ^~~~~~
/home/tkloczko/rpmbuild/BUILD/superlu-6.0.1/EXAMPLE/cfgmr.c:38:13: note: previous declaration of ‘caxpy_’ with type ‘void(int *, complex *, complex *, int *, complex *, int *)’
   38 | extern void caxpy_(int *, complex *, complex *, int *, complex *, int *);
      |             ^~~~~~
make[2]: *** [EXAMPLE/CMakeFiles/citersol.dir/build.make:93: EXAMPLE/CMakeFiles/citersol.dir/cfgmr.c.o] Error 1

[wo80]

@kloczek Which BLAS provider are you using? If you intended to use the internal CBLAS provided by SuperLU, have you set enable_internal_blaslib?

[kloczek]

flexiblas 3.3.1

[wo80]

@kloczek Did previous versions of SuperLU compile using flexiblas? I see some changes affecting the prototypes in cfgmr in 332cf3e , but that was before the release of 6.0.0. ...

[kloczek]

@kloczek Did previous versions of SuperLU compile using flexiblas? I see some changes affecting the cfgmr prototype in 332cf3e , but that was before the release of 6.0.0. ...

Just checked my build infra build logs (generated At 22 Jun) which stores record of correctly build 6.0.0 packages.

[wo80]

I think the problem might be the specified return type void instead of int of caxpy_ in citersol. Though I couldn't find a commit that affected the prototype between 6.0.0 and 6.0.1. Other examples using *axpy_ might also be affected.

EDIT: see comment below ...

[wo80]

Double checked void should be correct. So the return type int in cfgmr is wrong, should be void.

superlu/EXAMPLE/cfgmr.c

Lines 79 to 82 in d6a031c

	/* prototypes */
	extern int ccopy_(int *, complex *, int *, complex *, int *);
	extern int caxpy_(int *, complex *, complex [], int *, complex [], int *);

EDIT:
The duplicate but correct definition was removed in commit 5ad0fe1 - after release of 6.0.0

[xiaoyeli]

I have done these. Sherry Li

…

On Sun, Aug 6, 2023 at 2:48 AM Christoph Grüninger ***@***.***> wrote: Thank you for creating a 6.0.1 release! I am on my way to update the openSuse package. Before I close this issue, could you please update the homepage and mention 6.0.1 there and update the most recent Doxygen documentation? — Reply to this email directly, view it on GitHub <#106 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZSV5ZLY5VVYVUSVBH2CPLXT5R7LANCNFSM6AAAAAA2CJLNK4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[gruenich]

Thank you for updating the documentation and the change log. The page itself still mentions v6.0.0 to be the latest... I am closing this issue, as I am fine with it.

The issue @kloczek brought up is discussed in #113, so no reason to keep this issue open.