[cmake] Simplify creation of tests #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruenich
force-pushed
the
feature/cmake-test-setup
branch
from
ef022e3 to
2a4038c
Compare
The variable only containts a single C file, it does not simplify the code, but make it more complicated without any benefit.
The varialbes (C|D|S|Z)LINTST only added an indirectection without any benefit.
Drop handling of output, ctest offers everything needed, everything else should not be part of tests. Remove runtest.cmake, as it is no longer needed.
At least when using CMake this is gone.
gruenich
force-pushed
the
feature/cmake-test-setup
branch
from
2a4038c to
3e344c6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split-up version of #112. @wo80, I hope you do not feel offended by me chopping your merge request. I think this increases the quality of the contribution. Further, I hope that I did not introduce errors, it was a very manual task.
@xiaoyeli What do you think, do you pref this over #112?